[flang-commits] [PATCH] D140040: [flang] Lower binary and unary elemental array operations

[Valentin Clement via Phabricator via flang-commits]

clementval added a comment.

LGTM. Small comment about the unknown extent value.



================
Comment at: flang/include/flang/Optimizer/Builder/HLFIRTools.h:204
+/// allocatables if needed). Do nothing if the entity is already a value, and
+/// only dereference pointers and allocatables if if it is not a scalar entity
+/// of numerical or logical type.
----------------



================
Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROpBase.td:77
     }
+    static constexpr int getUnknownExtent() {return -1;}
   }];
----------------
Should we use `mlir::ShapedType::kDynamic` as in FIR? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140040/new/

https://reviews.llvm.org/D140040