[flang-commits] [PATCH] D140031: [flang][NFC] add builder to simplify fir.shape creation

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/lib/Lower/ConvertExpr.cpp:7275
 bool isParentComponent(const Fortran::lower::SomeExpr &expr) {
-  if (const Fortran::semantics::Symbol * symbol{GetLastSymbol(expr)}) {
+  if (const Fortran::semantics::Symbol *symbol{GetLastSymbol(expr)}) {
     if (symbol->test(Fortran::semantics::Symbol::Flag::ParentComp))
----------------
PeteSteinfeld wrote:
> When I run clang-format on this line, I get the following:
> ```
>   if (const Fortran::semantics::Symbol * symbol{GetLastSymbol(expr)}) {
> ```
> Note the space between the "*" and "symbol".
Thanks, I reverted that change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140031/new/

https://reviews.llvm.org/D140031