[flang-commits] [PATCH] D139351: Lowering and runtime support for F08 transformational intrinsics: BESSEL_JN and BESSEL_YN

[Slava Zakharin via Phabricator via flang-commits]

vzakhari added a comment.

Thank you for the explanantion and the changes! We can assert that `n1` and `n2` are non-negative later, if we decide to be more verbose in runtime.



================
Comment at: flang/unittests/Runtime/Transformational.cpp:342
+  }
+}
+
----------------
Can you please add a unit test for `BesselYnX0_16`?  We've had issues before that `std::numeric_limits` was not fully implemented for `CppTypeFor<TypeCategory::Real, 16>` (e.g. D134496).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139351/new/

https://reviews.llvm.org/D139351