[flang-commits] [PATCH] D139426: [flang] hlfir.assign default implementation

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.

Aside from the one nit, all builds and tests correctly and looks good.



================
Comment at: flang/lib/Optimizer/HLFIR/Transforms/ConvertToFIR.cpp:266
+    // TODO: like "bufferize-hlfir" pass, runtime signature may be added
+    // by this pass. This require the pass to run on the ModuleOp. It would
+    // probably be more optimal to have it run on FuncOp and find a way to
----------------
Should read "This requires ..."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139426/new/

https://reviews.llvm.org/D139426