[flang-commits] [PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

In D121171#3425946 <https://reviews.llvm.org/D121171#3425946>, @clementval wrote:

> 



> Most of the passes have a disable option when included in the pipeline. I agree that we might not need it right now but why delay a one line option that will for sure be useful in development and testing.

For testing specific passes, we can already use `fir-opt`. And if we want this pass to be controlled with a flag, then we will need to add it separately in `flang-new` and `tco`. That's going to be more than one line. In general, I think that using `fir-opt` in such scenarios (instead of introducing extra flags) is cleaner and clearer.

I'm also wondering - if mangling is going to be platform specific, then perhaps we need options to specify the platform to mangle for instead? This way, we can specify in tests:

  ! RUN: flang-new -fc1 -internal-name-mangling=linux -emit-llvm file.f90

This way, we would be able to keep our tests platform-agnostic (and everything would be future proof). This would also be more flexible than plain "disable"/"enable" toggle. WDTY?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171