[flang-commits] [PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

[Diana Picus via Phabricator via flang-commits]

rovka added a comment.

In D121171#3425946 <https://reviews.llvm.org/D121171#3425946>, @clementval wrote:

> In D121171#3425860 <https://reviews.llvm.org/D121171#3425860>, @awarzynski wrote:
>
>>> Do we still want to add a flag to optionally disable this pass?
>>
>> Depends on our end goal here. @schweitz mentioned  Windows interoperability. I guess that the mangling will be different on other platforms too? We could add the flag to disable `ExternalNameConversionPass` and then use it in tests so that:
>
> Most of the passes have a disable option when included in the pipeline. I agree that we might not need it right now but why delay a one line option that will for sure be useful in development and testing.

That sounds like a good idea to me, I'll add an option and use it in this test. I'll send a new patch probably tomorrow or so.

Thanks for all the comments so far!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171