[flang-commits] [PATCH] D122899: [flang] add evaluate::IsAllocatable helper

[Peixin Qiao via Phabricator via flang-commits]

peixin added inline comments.


================
Comment at: flang/lib/Semantics/check-call.cpp:404
       dummy.attrs.test(characteristics::DummyDataObject::Attr::Allocatable)};
-  bool actualIsAllocatable{
-      actualLastSymbol && IsAllocatable(*actualLastSymbol)};
+  bool actualIsAllocatable{evaluate::IsAllocatable(actual)};
   if (dummyIsAllocatable) {
----------------
This fix is not tested in this patch. So can you move the test case in call05.f90 in D122779 to this case? D122779 will focus on the other check (The actual argument shall have deferred the same type parameters as the dummy argument if the argument is allocatable or pointer variable). It's better to keep one patch as complete.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122899/new/

https://reviews.llvm.org/D122899