[flang-commits] [PATCH] D122899: [flang] add evaluate::IsAllocatable helper

[Peixin Qiao via Phabricator via flang-commits]

peixin added inline comments.


================
Comment at: flang/include/flang/Evaluate/tools.h:917
 
+bool IsAllocatable(const Expr<SomeType> &expr);
+
----------------
Nit: Remove expr to be consistent with others.


================
Comment at: flang/lib/Evaluate/tools.cpp:1097
 
+bool IsAllocatable(const Expr<SomeType> &expr) {
+  if (const semantics::Symbol *
----------------
Should you add one comment (2018 9.5.3 NOTE 2) here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122899/new/

https://reviews.llvm.org/D122899