[flang-commits] [flang] 2ba572a - [fir] Remove createConcatenate test temporarily

Valentin Clement via flang-commits flang-commits at lists.llvm.org
Thu Oct 21 13:41:10 PDT 2021


Author: Valentin Clement
Date: 2021-10-21T22:40:19+02:00
New Revision: 2ba572a82a35051cdee91f6bb00d3db322ae13a3

URL: https://github.com/llvm/llvm-project/commit/2ba572a82a35051cdee91f6bb00d3db322ae13a3
DIFF: https://github.com/llvm/llvm-project/commit/2ba572a82a35051cdee91f6bb00d3db322ae13a3.diff

LOG: [fir] Remove createConcatenate test temporarily

This test is makeing one buildbot fail for unknown reason. Remove
it until we can investifate further.

Added: 
    

Modified: 
    flang/unittests/Optimizer/Builder/CharacterTest.cpp

Removed: 
    


################################################################################
diff  --git a/flang/unittests/Optimizer/Builder/CharacterTest.cpp b/flang/unittests/Optimizer/Builder/CharacterTest.cpp
index 52da7a77ae60..64daf9494f69 100644
--- a/flang/unittests/Optimizer/Builder/CharacterTest.cpp
+++ b/flang/unittests/Optimizer/Builder/CharacterTest.cpp
@@ -62,26 +62,6 @@ TEST_F(CharacterTest, smallUtilityFunctions) {
       fir::factory::CharacterExprHelper::getCharacterKind(ty));
 }
 
-TEST_F(CharacterTest, createConcatenate) {
-  auto builder = getBuilder();
-  auto loc = builder.getUnknownLoc();
-  auto charHelper = fir::factory::CharacterExprHelper(builder, loc);
-  llvm::StringRef lhs("rightsideofconcat");
-  llvm::StringRef rhs("leftsideofconcat");
-  auto strLitLhs = fir::factory::createStringLiteral(builder, loc, lhs);
-  auto strLitRhs = fir::factory::createStringLiteral(builder, loc, rhs);
-  auto concat = charHelper.createConcatenate(
-      *strLitRhs.getCharBox(), *strLitLhs.getCharBox());
-  EXPECT_TRUE(mlir::isa<arith::AddIOp>(concat.getLen().getDefiningOp()));
-  auto addOp = dyn_cast<arith::AddIOp>(concat.getLen().getDefiningOp());
-  EXPECT_TRUE(mlir::isa<ConstantOp>(addOp.lhs().getDefiningOp()));
-  auto lhsCstOp = dyn_cast<ConstantOp>(addOp.lhs().getDefiningOp());
-  EXPECT_TRUE(mlir::isa<ConstantOp>(addOp.rhs().getDefiningOp()));
-  auto rhsCstOp = dyn_cast<ConstantOp>(addOp.rhs().getDefiningOp());
-  checkIntegerConstant(lhsCstOp, builder.getCharacterLengthType(), 16);
-  checkIntegerConstant(rhsCstOp, builder.getCharacterLengthType(), 17);
-}
-
 TEST_F(CharacterTest, createSubstring) {
   auto builder = getBuilder();
   auto loc = builder.getUnknownLoc();


        


More information about the flang-commits mailing list