[flang-commits] [PATCH] D113086: [flang] Add a semantics test for co_reduce

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a subscriber: klausler.
kiranchandramohan added a comment.

As @ekieri says you can submit with approval from another member of the community who works in this area.
If you have questions, the expert in this area (Parsing, Semantics, Runtime) is @klausler. You may add him for review.

Regarding the tests, I would like to understand the scope. I see a lot of restrictions for the arguments like the following. To exhaustively test, we will have to give A as polymorphic and coindexed, the OPERATION with more than two arguments, disallowed kind of results and arguments etc.
co_reduce(A, OPERATION [,RESULT_IMAGE, STAT, ERRMSG)
i. A should not be polymorphic, shall not be coindexed
ii. OPERATION shall be pure with two arguments, result and each argument shall be a scalar, nonallocatable, nonpointer, nonpolymorphic data object, with the same type and parameters as A. Similarity of properties (Volatile, Target, Value) for both arguments. The OPERATION shall be associative.

If this covers only a subset of the situations please mention that in the comment. We can build up the tests over time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086