[flang-commits] [PATCH] D113086: [flang] Add a semantics test for co_reduce

[Emil Kieri via Phabricator via flang-commits]

ekieri added a comment.

In D113086#3139018 <https://reviews.llvm.org/D113086#3139018>, @rouson wrote:

> @kiranchandramohan with your approval and that of @ktras, I just pushed differential D113076 <https://reviews.llvm.org/D113076>.  Could you review and approve this one along with differential D113077 <https://reviews.llvm.org/D113077>, D113083 <https://reviews.llvm.org/D113083>, and D113084 <https://reviews.llvm.org/D113084>?  Also, could you point me to a policy on what approvals are needed in order to push commits to main?

Hi, and thanks for working on this! Please see https://llvm.org/docs/DeveloperPolicy.html and https://llvm.org/docs/CodeReview.html. In summary, you may push when at least one reviewer has approved the patch, and all comments (by anyone) have been addressed. It can also be nice to let att least 24h pass between the first post of the patch and the push, to give people across all time zones a chance to comment, especially if the patch may be controversial in some way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086