[flang-commits] [PATCH] D113312: [flang] Make subscript list argument a nullable pointer

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Nov 8 08:35:14 PST 2021


klausler added inline comments.


================
Comment at: flang/runtime/type-info.cpp:174
 FILE *DerivedType::Dump(FILE *f) const {
-  std::fprintf(
-      f, "DerivedType @ 0x%p:\n", reinterpret_cast<const void *>(this));
+  std::fprintf(f, "DerivedType @ %p:\n", reinterpret_cast<const void *>(this));
   const std::uint64_t *uints{reinterpret_cast<const std::uint64_t *>(this)};
----------------
rovka wrote:
> Why are you removing all the 0x? Seems off-topic.
Because I noticed that the dump output had "0x0x" in it as I was debugging the problem, so I cleaned that up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113312/new/

https://reviews.llvm.org/D113312



More information about the flang-commits mailing list