[flang-commits] [PATCH] D113312: [flang] Make subscript list argument a nullable pointer

[Diana Picus via Phabricator via flang-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM, but I think it would look even better if the terminator were the first parameter (instead of breaking up the flow of the other parameters).



================
Comment at: flang/runtime/type-info.cpp:174
 FILE *DerivedType::Dump(FILE *f) const {
-  std::fprintf(
-      f, "DerivedType @ 0x%p:\n", reinterpret_cast<const void *>(this));
+  std::fprintf(f, "DerivedType @ %p:\n", reinterpret_cast<const void *>(this));
   const std::uint64_t *uints{reinterpret_cast<const std::uint64_t *>(this)};
----------------
Why are you removing all the 0x? Seems off-topic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113312/new/

https://reviews.llvm.org/D113312