[flang-commits] [PATCH] D99665: [flang] Refine checks for pointer initialization targets

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

All builds, tests, and looks good.



================
Comment at: flang/lib/Evaluate/check-expression.cpp:264
+  bool CheckVarOrComponent(const semantics::Symbol &symbol) {
+    const Symbol &ultimate{symbol.GetUltimate()};
+    if (IsAllocatable(ultimate)) {
----------------
Should this call to `GetUltimate()` be to `GetAssociationRoot()`?


================
Comment at: flang/lib/Evaluate/check-expression.cpp:614
   Result operator()(const semantics::Symbol &symbol) const {
-    if (symbol.attrs().test(semantics::Attr::CONTIGUOUS) ||
-        symbol.Rank() == 0) {
+    const auto &ultimate{symbol.GetUltimate()};
+    if (ultimate.attrs().test(semantics::Attr::CONTIGUOUS) ||
----------------
Should this be a call to `GetAssociationRoot()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99665/new/

https://reviews.llvm.org/D99665