[flang-commits] [PATCH] D98256: [flang] Save AllocateObject and PointerObject analyzed expression

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

These changes build,install, and look good.

Note that (unrelated to these changes), my latest version of clang-format shows that there's an extra blank line at line 3735 in parse-tree.h.

Also, when I was working on a bug in check-nullify.cpp, I was initially baffled by the fact that the analysis of the PointerObject's wasn't done in expression analysis rather than in semantic checking.  Do you know what the trade-offs are for analyzing expressions for ALLOCATE, DEALLOCATE, and NULLIFY expressions in semantic analysis rather than expression analysis?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98256/new/

https://reviews.llvm.org/D98256