[flang-commits] [PATCH] D104330: [flang] Complain about more cases of calls to insufficiently defined procedures

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld requested changes to this revision.
PeteSteinfeld added a comment.
This revision now requires changes to proceed.

Things build OK, but I when I run the tests, I get failures in implicit07.f90 and resolve29.f90.

Also, I wonder about the two identical error messages in characteristics.cpp.



================
Comment at: flang/lib/Evaluate/characteristics.cpp:473-475
+                "Procedure '%s' is referenced before being sufficiently defined in a context where it must be so"_err_en_US,
+                symbol.name());
+            return std::optional<Procedure>{};
----------------
Is this the error message that you meant to use for something that has `EntityDetails`?  In particular, this message is identical to the message below for something with `SubprogramNameDetails`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104330/new/

https://reviews.llvm.org/D104330