[flang-commits] [PATCH] D104325: [flang] Correct the subscripts used for arguments to character intrinsics

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: PeteSteinfeld.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
klausler requested review of this revision.

When chasing down another unrelated bug, I noticed that the
implementations of various character intrinsic functions assume
that the lower bounds of (some of) their arguments were 1.
This isn't necessarily the case, so I've cleaned them up, tweaked
the unit tests to exercise the fix, and regularized the allocation
pattern used for results to use SetBounds() before Allocate() rather
than the old original Descriptor::Allocate() wrapper around
CFI_allocate().

Since there were few other remaining uses of the old original
Descriptor::Allocate() wrapper, I also converted them to the
new one and deleted the old one.


https://reviews.llvm.org/D104325

Files:
  flang/runtime/character.cpp
  flang/runtime/descriptor.cpp
  flang/runtime/descriptor.h
  flang/runtime/transformational.cpp
  flang/unittests/Evaluate/reshape.cpp
  flang/unittests/RuntimeGTest/CharacterTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104325.352270.patch
Type: text/x-patch
Size: 14167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20210615/3fb72fc3/attachment.bin>