[flang-commits] [PATCH] D104019: [flang] Add initial implementation for CPU_TIME

[Diana Picus via Phabricator via flang-commits]

rovka added inline comments.


================
Comment at: flang/unittests/RuntimeGTest/Time.cpp:19
+  // Doing some writes to a volatile variable should do the trick.
+  for (int i = 0; i < (1 << 8); ++i)
+    x = i;
----------------
jeanPerier wrote:
> nit: other runtime test files also uses brace around single line for. Only lib/[Optmizer|Lower],  and include/flang/[Optmizer|Lower] files are using llvm convention there.
Derp, I missed that one... 

Would be nice to add to the clang-tidy config, I'm trying to put together a [[ https://reviews.llvm.org/D104100 | patch ]] for that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104019/new/

https://reviews.llvm.org/D104019