[flang-commits] [PATCH] D103654: [flang] CheckConformance: tristate-ify result

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Jun 3 15:55:48 PDT 2021


klausler created this revision.
klausler added a reviewer: jeanPerier.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
klausler requested review of this revision.

To ensure that errors are emitted by CheckConformance and
its callers in all situations, it's necessary for the returned result
of that function to distinguish between three possible
outcomes: the arrays are known to conform at compilation time,
the arrays are known to not conform (and a message has been
produced), and an indeterminate result in which is not possible
to determine conformance.  So convert CheckConformance's
result into an optional<bool>, and convert its confusing
Boolean flag arguments into a bit-set of named flags too.


https://reviews.llvm.org/D103654

Files:
  flang/include/flang/Evaluate/characteristics.h
  flang/include/flang/Evaluate/shape.h
  flang/lib/Evaluate/characteristics.cpp
  flang/lib/Evaluate/check-expression.cpp
  flang/lib/Evaluate/fold-implementation.h
  flang/lib/Evaluate/shape.cpp
  flang/lib/Semantics/check-call.cpp
  flang/lib/Semantics/expression.cpp
  flang/lib/Semantics/pointer-assignment.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103654.349717.patch
Type: text/x-patch
Size: 10912 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20210603/4b4f79a2/attachment.bin>


More information about the flang-commits mailing list