[flang-commits] [PATCH] D103540: [flang] Enabling flang to build with BUILD_SHARED_LIBS=On

Richard Barton via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Jun 3 00:55:54 PDT 2021


richard.barton.arm added a comment.

> The change does NOT appear to be necessary for main of llvm-project, however I could reproduce it with fir-dev branch of f18-llvm-project. I was told that changes to this file should go through phabricator and percolate to fir-dev.

I don't understand that. If there is a build issue on fir-dev but not on main then the bugfix only needs to go on fir-dev and not main. When the extra code on fir-dev that causes the bug comes to main then the bugfix can come with it at that point. main has buildbots for shared libs that ensure we notice it if that happens.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103540/new/

https://reviews.llvm.org/D103540



More information about the flang-commits mailing list