[flang-commits] [PATCH] D103567: [flang] Fix crashes due to failure to find a subprogram

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski accepted this revision.
awarzynski added a comment.

LGTM, thanks. Before merging, could you please fix the `clang-tidy` warning? No need to upload another version here.



================
Comment at: flang/lib/Semantics/tools.cpp:85
+    return nullptr;
+  } else {
+    const Scope &scope{GetProgramUnitContaining(start)};
----------------
As pointed out by `clang-tidy`, you can skip `else` here without changing the semantics: https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103567/new/

https://reviews.llvm.org/D103567