[flang-commits] [PATCH] D106727: [flang] Produce proper "preprocessor output" for -E option

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

LGTM. This patch is much appreciated and thank you for addressing my comments.



================
Comment at: flang/lib/Parser/parsing.cpp:113
+      inContinuation = false;
+      ++sourceLine;
+    } else {
----------------
klausler wrote:
> awarzynski wrote:
> > If you insert `continue` after `++sourceLine`, you can avoid the following `else` block. That's also one level of indentation less, which makes things easier to read.
> Adding gotos, however spelled, tends to make code harder to follow than simple nested structures.  No.
`continue` is not `goto`.  Also: https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106727/new/

https://reviews.llvm.org/D106727