[flang-commits] [PATCH] D106727: [flang] Produce proper "preprocessor output" for -E option

Peter Klausler via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Jul 30 08:48:17 PDT 2021


klausler marked 2 inline comments as done.
klausler added inline comments.


================
Comment at: flang/lib/Parser/parsing.cpp:113
+      inContinuation = false;
+      ++sourceLine;
+    } else {
----------------
awarzynski wrote:
> If you insert `continue` after `++sourceLine`, you can avoid the following `else` block. That's also one level of indentation less, which makes things easier to read.
Adding gotos, however spelled, tends to make code harder to follow than simple nested structures.  No.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106727/new/

https://reviews.llvm.org/D106727



More information about the flang-commits mailing list