[flang-commits] [flang] 2ca8295 - Fix unit test checks for the scalar cases of all/any intrinsics. I

Mark Leair via flang-commits flang-commits at lists.llvm.org
Thu Jul 29 15:08:21 PDT 2021


Author: Mark Leair
Date: 2021-07-29T15:07:19-07:00
New Revision: 2ca8295c860f1e8e300c2fde5c4e84b72d8248aa

URL: https://github.com/llvm/llvm-project/commit/2ca8295c860f1e8e300c2fde5c4e84b72d8248aa
DIFF: https://github.com/llvm/llvm-project/commit/2ca8295c860f1e8e300c2fde5c4e84b72d8248aa.diff

LOG: Fix unit test checks for the scalar cases of all/any intrinsics. I
accidentally used int64 when they should have been int32. This lead to
a Windows build unit test error (Linux did not catch the problem).

Differential Revision: https://reviews.llvm.org/D107107

Added: 
    

Modified: 
    flang/unittests/RuntimeGTest/Reduction.cpp

Removed: 
    


################################################################################
diff  --git a/flang/unittests/RuntimeGTest/Reduction.cpp b/flang/unittests/RuntimeGTest/Reduction.cpp
index 1750b914f0f88..d5dc54160c440 100644
--- a/flang/unittests/RuntimeGTest/Reduction.cpp
+++ b/flang/unittests/RuntimeGTest/Reduction.cpp
@@ -306,7 +306,7 @@ TEST(Reductions, Logical) {
   Descriptor &scalarResult{statDesc0.descriptor()};
   RTNAME(AllDim)(scalarResult, *array1, /*DIM=*/1, __FILE__, __LINE__);
   EXPECT_EQ(scalarResult.rank(), 0);
-  EXPECT_EQ(*scalarResult.ZeroBasedIndexedElement<std::int64_t>(0), 0);
+  EXPECT_EQ(*scalarResult.ZeroBasedIndexedElement<std::int32_t>(0), 0);
   scalarResult.Destroy();
   RTNAME(AnyDim)(res, *array, /*DIM=*/1, __FILE__, __LINE__);
   EXPECT_EQ(res.rank(), 1);
@@ -328,7 +328,7 @@ TEST(Reductions, Logical) {
   // A scalar result occurs when you have a rank 1 array.
   RTNAME(AnyDim)(scalarResult, *array1, /*DIM=*/1, __FILE__, __LINE__);
   EXPECT_EQ(scalarResult.rank(), 0);
-  EXPECT_EQ(*scalarResult.ZeroBasedIndexedElement<std::int64_t>(0), 1);
+  EXPECT_EQ(*scalarResult.ZeroBasedIndexedElement<std::int32_t>(0), 1);
   scalarResult.Destroy();
   RTNAME(ParityDim)(res, *array, /*DIM=*/1, __FILE__, __LINE__);
   EXPECT_EQ(res.rank(), 1);


        


More information about the flang-commits mailing list