[flang-commits] [PATCH] D106727: [flang] Produce proper "preprocessor output" for -E option

[Peter Klausler via Phabricator via flang-commits]

klausler marked 6 inline comments as done.
klausler added inline comments.


================
Comment at: flang/lib/Parser/parsing.cpp:155
+        inContinuation = true;
+      } else if (fixedForm && !inDirective && column < 7 && ch != ' ' &&
+          (ch < '0' || ch > '9')) {
----------------
awarzynski wrote:
> Non-digit in the first 6 columns (fixed form) is an error, right? Why not assert or issue a diagnostic here? This could hide a potential bug.
It would be an error if we were examining the original source file, yes, but this code runs later in compilation when we are reformatting the cooked character stream, from which excess spaces have been removed by prescanning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106727/new/

https://reviews.llvm.org/D106727