[flang-commits] [PATCH] D106726: [flang][msvc] Fix external-io unittest.

[Michael Kruse via Phabricator via flang-commits]

Meinersbur added a comment.

In D106726#2905066 <https://reviews.llvm.org/D106726#2905066>, @awarzynski wrote:

> I don't have a Windows machine to test this on, but this looks fairly straightforward and I think that it is safe to approve it as is. I think that Phabricator's CI would highlight any potential issues with this.

I just pushed the patch. That is, when https://reviews.llvm.org/D105315 is updated and the pre-merge bot runs again (maybe re-upload the same diff again?),we should see the result.

> Does it make sense to make D105315 <https://reviews.llvm.org/D105315>  depend on this and let the CI on Phabricator test it for us?

Since I just pushed the patch, it does not matter. Otherwise it could have made sense such that the pre-merge builder would apply this patch beforehande before compiling D105315 <https://reviews.llvm.org/D105315>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106726/new/

https://reviews.llvm.org/D106726