[flang-commits] [PATCH] D106820: [flang] Fix runtime ICE with maxloc and scalar result

Pete Steinfeld via Phabricator via flang-commits flang-commits at lists.llvm.org
Mon Jul 26 13:13:46 PDT 2021


PeteSteinfeld added inline comments.


================
Comment at: flang/runtime/reduction.cpp:272
+       */
+      if (result.rank() == 0 && result.Elements() == 1)
+        at[0] = 1; // needed for handling scalar result below.
----------------
It would be good to clean up these clang-tidy warnings about not having braces around single statement "if-then" blocks here and at line 327 below.  It looks like everywhere else in the file such statements have braces around them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106820/new/

https://reviews.llvm.org/D106820



More information about the flang-commits mailing list