[flang-commits] [PATCH] D106726: [flang][msvc] Fix external-io unittest.

Mon Jul 26 11:34:10 PDT 2021

awarzynski accepted this revision.
awarzynski added a comment.
This revision is now accepted and ready to land.

These changes make a lot of sense to me. This is making sure that WIN32 implementation is consistent with Linux/Unix and it fixes bugs that we probably missed because the affected tests are skipped on Windows.

I don't have a Windows machine to test this on, but this looks fairly straightforward and I think that it is safe to approve it as is. I think that Phabricator's CI would highlight any potential issues with this.

Does it make sense to make D105315 <https://reviews.llvm.org/D105315>  depend on this and let the CI on Phabricator test it for us?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106726/new/

https://reviews.llvm.org/D106726