[flang-commits] [PATCH] D106727: [flang] Produce proper "preprocessor output" for -E option

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

Thank you for submitting this. It will unblock https://gitlab.kitware.com/cmake/cmake/-/issues/22387, which is quite an important milestone for Flang.

With this change, tests in https://github.com/llvm/llvm-project/tree/main/flang/test/Preprocessing require re-formatting or they will start failing.

Also, could a regression test be added that fails without your change? For example:

  ! Verify that the output from `-E` is valid fixed-form source. See
  ! https://bugs.llvm.org/show_bug.cgi?id=50993.
  
  ! RUN: %flang_fc1 -E %s 2>&1 | %flang_fc1 -fsyntax-only -ffixed-form 2>&1 | FileCheck %s --allow-empty
  
  ! CHECK-NOT: error
  ! CHECK-NOT: warning
  
  ! https://bugs.llvm.org/show_bug.cgi?id=51219
  ! CHECK-NOT: Character in fixed-form label field must be a digit
  
        PROGRAM HELLO
          write(*, *), "hello, world!"
        END PROGRAM

Feel free to edit and re-use this one ^^^. I also created https://bugs.llvm.org/show_bug.cgi?id=5121.9. Otherwise that final `CHECK-NOT` above is confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106727/new/

https://reviews.llvm.org/D106727