[flang-commits] [PATCH] D106170: [flang] Runtime API for data pointers

[Peter Klausler via flang-commits]

Will do, thanks.

-----Original Message-----
From: David Spickett via Phabricator <reviews at reviews.llvm.org> 
Sent: Tuesday, July 20, 2021 2:20 AM
To: Peter Klausler <pklausler at nvidia.com>; Jean Perier <jperier at nvidia.com>
Cc: david.spickett at linaro.org; llvm-commits at lists.llvm.org; mgorny at gentoo.org; jdoerfert at anl.gov; flang-commits at lists.llvm.org; Renaud Kauffmann <rkauffmann at nvidia.com>; bhuvanendra.kumarn at amd.com; 88888yl at gmail.com; Peter Steinfeld <psteinfeld at nvidia.com>; aperry at lanl.gov; tim at tkeith.com; clementval at gmail.com; sourabhsingh.tomar at amd.com; dougpuob at gmail.com; Steve Scalpone <sscalpone at nvidia.com>; isuruf at gmail.com; kiranchandramohan at gmail.com; Eric Schweitz <eschweitz at nvidia.com>; v.churavy at gmail.com; kuhnel at google.com
Subject: [PATCH] D106170: [flang] Runtime API for data pointers

External email: Use caution opening links or attachments


DavidSpickett added a comment.

This change has broken the flang build on our latest-gcc bot:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flab.llvm.org%2Fbuildbot%2F%23%2Fbuilders%2F160%2Fbuilds%2F3224&data=04%7C01%7Cpklausler%40nvidia.com%7Cc3883d99c103400f7e2008d94b5f7fc8%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637623695857941938%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=636QthwCwfKSeWgaDFAfBSfry%2F2p1QeacHXOEyCVSHU%3D&reserved=0

  ../llvm-project/flang/runtime/descriptor.h:52:22: error: array subscript 'Fortran::runtime::Dimension[1]' is partly outside array bounds of 'Fortran::runtime::StaticDescriptor<0, true> [1]' [-Werror=array-bounds]
     52 |     raw_.lower_bound = lower;
        |     ~~~~~~~~~~~~~~~~~^~~~~~~
  ../llvm-project/flang/runtime/descriptor-io.cpp:35:31: note: while referencing 'statDesc'
     35 |     StaticDescriptor<0, true> statDesc;
        |                               ^~~~~~~~

Though it has gone through latest-clang fine: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flab.llvm.org%2Fbuildbot%2F%23%2Fbuilders%2F180%2Fbuilds%2F440&data=04%7C01%7Cpklausler%40nvidia.com%7Cc3883d99c103400f7e2008d94b5f7fc8%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637623695857941938%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=xp6PCjyP7Di30Brn8lWAggSZe%2BwFih0jWQ%2FbotSNRaM%3D&reserved=0

So could be gcc being pessimistic or clang missing something.

Can you please investigate?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD106170%2Fnew%2F&data=04%7C01%7Cpklausler%40nvidia.com%7Cc3883d99c103400f7e2008d94b5f7fc8%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637623695857941938%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=YHJ0nPUl71DRgxE3nxEjhi42DeqWJoZsVdXX%2FjMPtp8%3D&reserved=0

https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD106170&data=04%7C01%7Cpklausler%40nvidia.com%7Cc3883d99c103400f7e2008d94b5f7fc8%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637623695857941938%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=1oA0v7%2Fa9Hk4XuzrZC8rC%2F4JWkNzW%2FlG1XLwaD0vOc8%3D&reserved=0