[flang-commits] [PATCH] D100897: [flang] Make 'team_number()' an intrinsic function

[Peter Klausler via Phabricator via flang-commits]

klausler added inline comments.


================
Comment at: flang/include/flang/Evaluate/type.h:132
 
+  static constexpr DynamicType MissingDerivedType() {
+    DynamicType result;
----------------
craig.rasmussen wrote:
> This function (whatever it is named) is critical to get team_number to work with a missing optional team arguments.  Otherwise the check  
> 
> CHECK(IsValidKindOfIntrinsicType(category_, kind_));
> 
> disallows the construction of a DynamicType that is not an intrinsic type.
> 
When the derived type TEAM_TYPE from intrinsic module ISO_FORTRAN_ENV is available, this MissingDerivedType() is not required, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100897/new/

https://reviews.llvm.org/D100897