[flang-commits] [PATCH] D108688: [flang] Add runtime interface for GET_COMMAND_ARGUMENT

Thu Aug 26 22:16:15 PDT 2021

rovka added a comment.

In D108688#2967602 <https://reviews.llvm.org/D108688#2967602>, @klausler wrote:

> In D108688#2966694 <https://reviews.llvm.org/D108688#2966694>, @rovka wrote:
>
>> In D108688#2965273 <https://reviews.llvm.org/D108688#2965273>, @klausler wrote:
>>
>>> The ERRMSG argument could be a nullable pointer argument to ArgumentValue.
>>
>> Why a nullable pointer and not a descriptor? I'm also wondering this about \p value, should that also be passed as a pointer + length rather than a descriptor?
>
> I mean the argument can be a pointer (not reference) to a descriptor, and the pointer can be null if there is no ERRMSG=.

Right, I got a bit confused there, thanks for clarifying :) I'll make both of them nullable, since it's clearer and simpler than having to check if the descriptor is allocated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108688/new/

https://reviews.llvm.org/D108688