[flang-commits] [PATCH] D108688: [flang] Add runtime interface for GET_COMMAND_ARGUMENT

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D108688#2966694 <https://reviews.llvm.org/D108688#2966694>, @rovka wrote:

> In D108688#2965273 <https://reviews.llvm.org/D108688#2965273>, @klausler wrote:
>
>> environment.h is not a header for APIs.
>
> Ok, should I move them to main.h, so they can sit next to ProgramStart? Seems like a nice place since they'd all be using executionEnvironment.

Fine.

>> The ERRMSG argument could be a nullable pointer argument to ArgumentValue.
>
> Why a nullable pointer and not a descriptor? I'm also wondering this about \p value, should that also be passed as a pointer + length rather than a descriptor?

I mean the argument can be a pointer (not reference) to a descriptor, and the pointer can be null if there is no ERRMSG=.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108688/new/

https://reviews.llvm.org/D108688