[flang-commits] [PATCH] D88163: [flang][msvc] Avoid templated initializer list initialization of vector. NFC.

[Michael Kruse via Phabricator via flang-commits]

Meinersbur added inline comments.


================
Comment at: flang/include/flang/Evaluate/constant.h:101
+  ConstantBase(ELEMENT &&x, Result res = Result{}) : result_{res} {
+    values_.push_back(std::move(x));
+  }
----------------
klausler wrote:
> This change will restrict this constructor to work only with scalar items, I think.
I was trying to find out when this could be the case. However, I think it just moved any implicit conversion from type `A`  to `ELEMENT` from happening from inside the ctor to the code that calls the ctor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88163/new/

https://reviews.llvm.org/D88163