[flang-commits] [PATCH] D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it.

[Valentin Clement via Phabricator via flang-commits]

clementval added a comment.

> IIUC, TableGen would check only for allowed, notallowed, etc and the restrictions in TableGen.
>
> Where would the other restrictions be checked?
> e.g `Enter(const parser::OmpScheduleClause &x)` there are too many checks.

That's not what I meant. What I meant is that lots of clauses have just trivial checks and therefore will just use the macros and nothing else. In your statement your were mentioning that those were just temporary but in my opinion (at least on the OpenACC side) they will stay as is since they do not have further restrictions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90324/new/

https://reviews.llvm.org/D90324