[flang-commits] [PATCH] D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added a comment.

In D90324#2366660 <https://reviews.llvm.org/D90324#2366660>, @clementval wrote:

>> So the macros are somewhat partial checks, having macros makes us easily figure out in this case whether the restrictions on clause are partially implemented or more detailed.
>
> I don't fully agree on this one. At least on the OpenACC side lots of clauses will have only those checks and thus keep the macro or TableGen style.

IIUC, TableGen would check only for allowed, notallowed, etc and the restrictions in TableGen.

Where would the other restrictions be checked?
e.g `Enter(const parser::OmpScheduleClause &x)` there are too many checks.

Are they done somewhere in OACC which I might be unaware of ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90324/new/

https://reviews.llvm.org/D90324