[flang-commits] [PATCH] D89583: [Flang][OpenMP] Semantic checks for Atomic construct.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:155
   void Enter(const parser::OmpClause::IsDevicePtr &);
+  // Memory-order-clause
+  void Enter(const parser::OmpClause::SeqCst &);
----------------
kiranchandramohan wrote:
> Thinking about this again. It will be good if we can retain memory-order-clause in the parse tree. Since the standard specifically talks about memory-order-clauses. If we write a frontend tool to list all memory order clauses then if there is a representation for memory-order-clause in the parse tree it will be easy to process all memory-order-clauses.
The whole discussion to change parser started when failing to implement semantic checks(given that we had code) without changing parser.

Reason being that `memory-order-clauses` were not part of `OmpClause` inside `openmp-parsers.cpp`.

I am happy to change it If that's possible.
Also if @clementval shares some opinions on this issue, he might have a better overview.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89583/new/

https://reviews.llvm.org/D89583