[flang-commits] [PATCH] D89583: [Flang][OpenMP] Semantic checks for Atomic construct.

Kiran Chandramohan via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed Oct 21 14:18:17 PDT 2020


kiranchandramohan added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:155
   void Enter(const parser::OmpClause::IsDevicePtr &);
+  // Memory-order-clause
+  void Enter(const parser::OmpClause::SeqCst &);
----------------
Thinking about this again. It will be good if we can retain memory-order-clause in the parse tree. Since the standard specifically talks about memory-order-clauses. If we write a frontend tool to list all memory order clauses then if there is a representation for memory-order-clause in the parse tree it will be easy to process all memory-order-clauses.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89583/new/

https://reviews.llvm.org/D89583



More information about the flang-commits mailing list