[flang-commits] [PATCH] D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct.

Sourabh Singh Tomar via Phabricator via flang-commits flang-commits at lists.llvm.org
Fri Oct 9 05:29:23 PDT 2020


SouraVX added inline comments.


================
Comment at: flang/lib/Parser/unparse.cpp:2267
     Word("!$OMP ATOMIC");
-    Walk(std::get<OmpAtomicMemoryOrderClauseList>(x.t));
+    Walk(std::get<0>(x.t));
     Word(" UPDATE");
----------------
NIT: Can't we use the type name here ? `get<0>` does the job but makes the code less readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88965/new/

https://reviews.llvm.org/D88965



More information about the flang-commits mailing list