[flang-commits] [PATCH] D88965: [Flang][OpenMP] Rework parser changes for OpenMP atomic construct.

Fri Oct 9 02:50:11 PDT 2020

sameeranjoshi added a comment.

> Sorry, I was not aware that they are going to be removed. I guess we can keep it till then.
> I would prefer keeping the unparsing since it provides a mechanism to 1) test the parser 
> and 2) do source to source translation.

Those are my personal understandings from how current `f18` behaves by unparsing and passing it to an external compiler specified by `F18_FC` , I am too unaware if unparsing would be removed officially, but if projects which might interest people are possible it's ideal to retain that.

> BTW, are allowed clauses and all handled automatically or will they require a separate patch?

I think semantic checks for atomic needs separate patch which might need to upgrade to OpenMP 5.0 changes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88965/new/

https://reviews.llvm.org/D88965