[flang-commits] [PATCH] D89879: [Flang][OpenMP-5.0] Semantic checks for flush construct.

Mon Nov 30 11:17:51 PST 2020

clementval added inline comments.

================
Comment at: flang/test/Semantics/omp-flush01.f90:28
+    !ERROR: expected end of line
+    !$omp flush acq_rel acq_rel
+    !ERROR: expected end of line
----------------
sameeranjoshi wrote:
> clementval wrote:
> > Why is the error reported twice here? Would it not be nicer to have a list of `memory-order-clause` and then the error being reported by the semantic check? I mean it would be more user friendly. 
> It's a known issue due the improper error recovery in openmp.
> omp-atomic.f90 file too had to get a workaround using the same way.
> 
> Yes, I have forwarded the errors to semantic phase.
If you have forwarded the errors to semantic then why is there still two syntax error lines? 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89879/new/

https://reviews.llvm.org/D89879