[flang-commits] [PATCH] D89879: [Flang][OpenMP-5.0] Semantic checks for flush construct.

[Valentin Clement via Phabricator via flang-commits]

clementval added a comment.

Some small comments



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:218
+      context_.Say(parser::FindSourceLocation(flushList),
+          "If memory-order-clause is RELEASE, ACQUIRE, or ACQ_REL, list items must not be specified on the FLUSH directive"_err_en_US);
+    }
----------------
Isn't this line exceeding the character limit? 


================
Comment at: flang/test/Semantics/omp-flush01.f90:28
+    !ERROR: expected end of line
+    !$omp flush acq_rel acq_rel
+    !ERROR: expected end of line
----------------
Why is the error reported twice here? Would it not be nicer to have a list of `memory-order-clause` and then the error being reported by the semantic check? I mean it would be more user friendly. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89879/new/

https://reviews.llvm.org/D89879