[flang-commits] [PATCH] D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it.

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

Looks OK to me. Couple of minor comments.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:13
+#include <algorithm>
 namespace Fortran::semantics {
 
----------------
Nit: Should there be a line before the namespace?


================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:489
+  std::string commaSeperatedMapTypes;
+  llvm::interleave(
+      allowedMapTypeList.begin(), allowedMapTypeList.end(),
----------------
Is  commaSeperatedMapTypes created (and not used) in cases where there is no error?


================
Comment at: flang/test/Semantics/omp-combined-constructs.f90:208
 
-  !ERROR: Only the TO, FROM, TOFROM, or ALLOC map types are permitted for MAP clauses on the TARGET TEAMS directive
   !$omp target teams map(delete:a)
----------------
#justsaying: I liked the "or" in the message. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90834/new/

https://reviews.llvm.org/D90834