[flang-commits] [PATCH] D91209: [flang] Fix CheckSpecificationExpr handling of associated names

[Andrzej Warzynski via Phabricator via flang-commits]

awarzynski added a comment.

Hi @klausler , thank you for working on this!

Sadly this is causing our public buildbots to fail:

- http://lab.llvm.org:8011/#/builders/33/builds/626
- http://lab.llvm.org:8011/#/builders/66/builds/440

I'm guessing that this patch wasn't tested with `BUILD_SHARED_LIBS=ON`? I always try to find and apply a fix for this kind of things, but in this case I'm struggling. IIUC, `FortranSemantics` is missing from the list of dependencies of `libflangEvaluate`:

  index a2fdc10896b..bbe7857cfc5 100644
  --- a/flang/lib/Evaluate/CMakeLists.txt
  +++ b/flang/lib/Evaluate/CMakeLists.txt
  @@ -42,6 +42,7 @@ add_flang_library(FortranEvaluate
     FortranCommon
     FortranDecimal
     FortranParser
  +  FortranSemantics
     ${LIBPGMATH}
  
     LINK_COMPONENTS

However, that introduces a circular dependency that CMake rejects:

  CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):
    "FortranEvaluate" of type SHARED_LIBRARY
      depends on "FortranSemantics" (weak)
    "FortranSemantics" of type SHARED_LIBRARY
      depends on "FortranEvaluate" (weak)
  At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries.

See here: https://gitlab.kitware.com/cmake/cmake/-/issues/17905

Perhaps I'm missing something obvious? I'm not really familiar with this codebase. I will revert this for now. It's a relatively small patch and hopefully that will not block anyone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91209/new/

https://reviews.llvm.org/D91209