[flang-commits] [PATCH] D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it.

[Valentin Clement via Phabricator via flang-commits]

clementval added a comment.

Thanks for moving those to TableGen and common infra. This makes lots of sense. Small comment about the list with comma.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:493
+        bool printComma{false};
+        for (const auto &mapType : allowedList) {
+          if (printComma)
----------------
Why not using `llvm::interleave` here? There are lots of example in the LLVM code base that do the same things. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90834/new/

https://reviews.llvm.org/D90834