[flang-commits] [PATCH] D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it.

sameeran joshi via Phabricator via flang-commits flang-commits at lists.llvm.org
Thu Nov 5 03:23:37 PST 2020


sameeranjoshi created this revision.
sameeranjoshi added reviewers: kiranchandramohan, clementval, kiranktp.
Herald added subscribers: guansong, yaxunl.
Herald added a project: LLVM.
sameeranjoshi requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.

`OmpStructureChecker` has too much boilerplate code in source file.

This patch:

1. Use helpers from `check-directive-structure.h` and reduces the boilerplate.
2. Use TableGen infrastructure as much as possible.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90834

Files:
  flang/lib/Semantics/check-omp-structure.cpp
  flang/lib/Semantics/check-omp-structure.h
  flang/test/Semantics/omp-clause-validity01.f90
  flang/test/Semantics/omp-combined-constructs.f90
  flang/test/Semantics/omp-device-constructs.f90
  llvm/include/llvm/Frontend/OpenMP/OMP.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90834.303069.patch
Type: text/x-patch
Size: 15079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20201105/450cc17b/attachment-0001.bin>


More information about the flang-commits mailing list