[flang-commits] [PATCH] D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause.

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi marked 3 inline comments as done.
sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:312
       Symbol::Flag::OmpFirstPrivate, Symbol::Flag::OmpLastPrivate,
-      Symbol::Flag::OmpReduction};
+      Symbol::Flag::OmpReduction, Symbol::Flag::OmpAligned};
 
----------------
kiranchandramohan wrote:
> Why does aligned require a new symbol?
Looks like I was in assumption that we need the same flags from flang/include/flang/Semantics/symbol.h.

I have removed it.


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:957
+    if (auto *resolvedSymbol{ResolveOmp(name, ompFlag, currScope())}) {
+      AddToContextObjectWithDSA(*resolvedSymbol, ompFlag);
+    }
----------------
kiranchandramohan wrote:
> Should we call AddToContextObjectWithDSA only for those flags which correspond to DSA (default, shared, private, lastprivate, firstprivate, linear)?
> 
Thanks for making me aware of that.
I have added a guard.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90538/new/

https://reviews.llvm.org/D90538