[flang-commits] [PATCH] D90538: [Flang][OpenMP] Fix 'Internal: no symbol found' for OpenMP aligned and linear clause.

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

Thanks @sameeranjoshi for this patch. Couple of questions inline.



================
Comment at: flang/lib/Semantics/resolve-directives.cpp:312
       Symbol::Flag::OmpFirstPrivate, Symbol::Flag::OmpLastPrivate,
-      Symbol::Flag::OmpReduction};
+      Symbol::Flag::OmpReduction, Symbol::Flag::OmpAligned};
 
----------------
Why does aligned require a new symbol?


================
Comment at: flang/lib/Semantics/resolve-directives.cpp:957
+    if (auto *resolvedSymbol{ResolveOmp(name, ompFlag, currScope())}) {
+      AddToContextObjectWithDSA(*resolvedSymbol, ompFlag);
+    }
----------------
Should we call AddToContextObjectWithDSA only for those flags which correspond to DSA (default, shared, private, lastprivate, firstprivate, linear)?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90538/new/

https://reviews.llvm.org/D90538