[flang-commits] [PATCH] D80377: [flang] Google test infrastructure support for unittests

[Eric Schweitz via Phabricator via flang-commits]

schweitz added inline comments.


================
Comment at: flang/CMakeLists.txt:132
          "Generate build targets for the Flang unit tests."
-         ${LLVM_INCLUDE_TESTS})
+         ON)
   set(FLANG_BINARY_DIR ${CMAKE_BINARY_DIR}/tools/flang)
----------------
richard.barton.arm wrote:
> kiranchandramohan wrote:
> > 1) Does this mean that the flang unit tests cannot be controlled using LLVM_INCLUDE_TESTS?
> > 2) Do you know why Clang/LLVM has unittests set to OFF by default?
> I don't think this is right. LLVM_INCLUDE_TESTS is On by default according to llvm/docs/CMake.rst. LLVM so we should be able to keep the original code. This is what the other LLVM sub-projects seem to do, i.e. give you a local toggle for the unit tests of the sub-project, but default to the global setting for unit tests.
> 
> Note there is LLVM_BUILD_TESTS, which defaults to OFF, that excludes the tests from the all target. This means the unittests will be built only on //make check-all// rather than on //make//.
> 
Agreed. This should not be changed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80377/new/

https://reviews.llvm.org/D80377