[flang-commits] [PATCH] D79442: [flang] Add examples in documentation/BijectiveInternalNameUniquing.md

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added a comment.

In D79442#2022726 <https://reviews.llvm.org/D79442#2022726>, @schweitz wrote:

> Thanks for adding these examples.
>
> A related addition would be to add a unittest that constructs and deconstructs the unique names.


I checked LLVM unittesting guidelines for writing tests using gtest and gmock.

I grepped for gtest.h and gmock.h, I ended up with no results.
Various macros(various types of ASSERTS... ) in gtest are not seen in flang/unittests/ folder.
As well various gtest related functions in main() are not seen, ex RUN_ALL_TESTS(), InitGoogleTest().

1. I am wondering why are other tests in the directory not using these features of gtest and still being under unittests/ folder?
2. If current tests which are already present belong to different aspect of testing the flang-compiler, is that ok to write BijectiveInternalNameUniquing tests using gtest way of doing things?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79442/new/

https://reviews.llvm.org/D79442